Repository navigation
fix: start window modification during qer rate limiting - #596
Merged
Merged
Conversation
pirog-spb
approved these changes
Mar 1, 2025
Collaborator
|
Good PR! Thanks! I'll create additional issue concerning inaccurate rate limiting. I guess, it's because of lost of accuracy during int - float - int conversions during rate limiting. |
Contributor
Author
Hi @pirog-spb. Thanks for the review and for creating the follow-up issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This pull request addresses a critical issue in the UPF QoS implementation where the QER rate limiting was not functioning correctly. The
qer->ul_startandqer->dl_startvalue, used to track the sliding window for rate limiting, was never updated, resulting in uncontrolled traffic rates. This PR corrects the rate limiting logic by properly updating the sliding window start time.Problem:
The
limit_rate_sliding_windowfunction was incorrectly modifying the pointer to the start time, rather than the start time itself. This resulted in the start time remaining at its initial value (zero), effectively disabling rate limiting.Solution:
This PR modifies the
limit_rate_sliding_windowfunction to directly update thewindows_startvalue.Testing:
To validate these changes, please refer to the testing instructions in the repository: https://gitlab.com/phine-oss/upf-qos-validation#251-integrating--eupf-ueransim-and-ues
Results:
qer->ul_startwas always zero.Known Issue/Further Improvement:
During testing, it was observed that the traffic capping was not perfectly accurate. For example, a requested rate of 20 Mbps resulted in approximately 13 Mbps. This discrepancy requires further investigation and potential refinement of the rate limiting algorithm. The current fix ensures that the rate is limited, but the exact accuracy requires further improvement.