Skip to content

tests: Add robot to CI - #352

Merged
kade-ddnkv merged 34 commits into
mainfrom
robot-experimetns
Oct 25, 2023
Merged

kade-ddnkv merged 34 commits into
mainfrom
robot-experimetns

Conversation

@marknefedov

Copy link
Copy Markdown
Contributor

No description provided.

@marknefedov marknefedov added the help wanted Extra attention is needed label Jul 19, 2023
@pirog-spb pirog-spb added this to the Nonfunctional features milestone Jul 20, 2023
@kade-ddnkv

Copy link
Copy Markdown
Contributor

Options where to place new Loadtest workflow:

  1. Inside a test.yml, just after all go and python tests (imho, bad choice for plenty of reasons)
  2. As an additional job inside test.yml with defined "needs" parameter, which will run only if first job (go and python tests) succeeded.
  3. As a separate workflow with trigger "workflow_run", so it will run only if workflow test.yml succeded. Best choice, I suppose, but the problem is that "workflow_run" trigger only works on default branch (main) pushes.
  4. As a separate workflow, which will run in parallel with all other tests.

Well, it is possible to combine (3) and (4) options:

  • run loadtest after other workflows on main branch
  • run loadtest in parallel on all other branches / PRs
  1. Make both test.yml and loadtest.yml workflows reusable. Create generic workflow, which will call them in right order.

@kade-ddnkv
kade-ddnkv marked this pull request as ready for review October 24, 2023 22:04
@kade-ddnkv
kade-ddnkv requested a review from pirog-spb October 24, 2023 22:04
@kade-ddnkv
kade-ddnkv merged commit 530be42 into main Oct 25, 2023
@pirog-spb
pirog-spb deleted the robot-experimetns branch April 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

help wanted Extra attention is needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants