Skip to content

Commit 0830fd1

Browse files
authored
Build the full wheel matrix weekly, not only at release (msgspec#1174)
`build-wheels.yml` skips every musllinux wheel unless `build-all` is true, and `ci.yml` only passes `build-all` on release. So no musllinux wheel, on any architecture, is built outside a release, and the first run that can show a musllinux breakage is the one meant to publish. msgspec#1134 hit exactly that when `cp310-musllinux_riscv64` failed on the 0.22.0 release build, and msgspec#1146 could not be exercised by its own CI for the same reason. **Change.** `ci.yml` gains a weekly `schedule` trigger (Monday 04:17 UTC) and passes `build-all` on `schedule` as well as on `release`, so the complete matrix, musllinux and riscv64 included, runs on a timer between releases. Pull request and push runs are unchanged, and so is the `build-riscv64` label gate. Five lines, no new jobs. **What proves it.** A workflow cannot run locally; the file parses as YAML. The first scheduled run showing the musllinux and riscv64 legs outside a release is the proof. If PR-time coverage is wanted as well, a single `cp312-musllinux_x86_64` smoke build gated on changes to the wheel workflow, `setup.py`, `pyproject.toml` or `src/` is a small follow-up; I left it out of this change so the schedule can land on its own. One question for the reviewer: is weekly the right cadence for the project's CI budget, or would you rather tie the full build to a pre-release tag? Closes msgspec#1150
1 parent 924f477 commit 0830fd1

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

‎.github/workflows/ci.yml‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,10 @@ on:
3535
release:
3636
types:
3737
- published
38+
schedule:
39+
# Weekly full wheel build (build-all), so a musllinux or riscv64 breakage
40+
# surfaces before the release run that would otherwise be the first to try it.
41+
- cron: '17 4 * * 1'
3842

3943
permissions: {}
4044

@@ -201,7 +205,7 @@ jobs:
201205
contents: read
202206
with:
203207
sdist-name: "${{ needs.prepare.outputs.sdist-name }}"
204-
build-all: ${{ github.event_name == 'release' }}
208+
build-all: ${{ github.event_name == 'release' || github.event_name == 'schedule' }}
205209

206210
upload-pypi:
207211
name: Upload artifacts to PyPI

0 commit comments

Comments
 (0)