Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: eddmann/santa-lang-comet
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.0.11
Choose a base ref
...
head repository: eddmann/santa-lang-comet
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.0.12
Choose a head ref
  • 3 commits
  • 5 files changed
  • 1 contributor

Commits on Dec 19, 2025

  1. fix: propagate errors from filter callbacks instead of swallowing them

    Previously, errors inside filter/map/filter_map callbacks were silently
    swallowed using `.ok()?`, treating them as end-of-iteration. Now errors
    are properly stored and propagated when the iterator is consumed.
    
    - Add error field to LazySequenceIter to capture callback errors
    - Update list(), reverse(), take(), flat_map() to check for errors
    - Add try_collect() helper for error-aware collection
    eddmann committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    31af8cf View commit details
    Browse the repository at this point in the history
  2. feat: make map and filter arity-aware for index/key passing

    Add arity() method to Function type and use it to conditionally pass
    index/key arguments to map and filter callbacks:
    
    - Lists/Strings: pass (element, index) only if arity >= 2
    - Dictionaries: pass (value, key) only if arity >= 2
    - Sets: unchanged (no meaningful index)
    
    This enables `map(max)` to work correctly while still supporting
    `map(|v, i| ...)` for accessing indices, matching Blitzen's behavior.
    eddmann committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    baeaf7f View commit details
    Browse the repository at this point in the history
  3. test: add coverage for arity-aware map/filter and error propagation

    Add tests for map and filter arity-aware index/key passing, and verify
    that errors in callbacks are properly propagated rather than swallowed.
    Also includes minor clippy fixes for iterator idioms.
    eddmann committed Dec 19, 2025
    Configuration menu
    Copy the full SHA
    8159a26 View commit details
    Browse the repository at this point in the history
Loading