Skip to content

fix(svg): encode HTML when converting vnode to string. #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
plainheart merged 1 commit into from
Jul 20, 2022
Merged

fix(svg): encode HTML when converting vnode to string. #935

plainheart merged 1 commit into from
Jul 20, 2022

Conversation

@plainheart
Copy link
Collaborator

@plainheart plainheart commented Jul 19, 2022

Fix apache/echarts#17399

Since we don't encode the SVG string, the generated SVG may be broken if it contains special characters.

And the encodeHTML function was moved from echarts to zrender in this PR.

@plainheart
fix(svg): encode HTML when converting vnode to string. fix apache/ech…
4617922 
…arts#17399.

- move the `encodeHTML` function from `echarts` to `zrender`.
@plainheart plainheart requested a review from pissang July 19, 2022 07:39
@plainheart plainheart mentioned this pull request Jul 19, 2022
Merged
8 tasks
@plainheart plainheart merged commit 6b32470 into master Jul 20, 2022
@plainheart plainheart deleted the svg-encode-html branch July 20, 2022 06:08
@plainheart plainheart mentioned this pull request Dec 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pissang pissang pissang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]The name of the series in the option contains label characters such as "<",">", which causes the generated svg to render incorrectly

3 participants

@plainheart @pissang