Skip to content

fix: export Displayable for type annotation compatibility #824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pissang merged 1 commit into from
Sep 14, 2021
Merged

fix: export Displayable for type annotation compatibility #824

pissang merged 1 commit into from
Sep 14, 2021

Conversation

@baojd42
Copy link

@baojd42 baojd42 commented Sep 13, 2021

Export Displayable so it can be used for type annotation, especially in the case below

import * as zrender from 'zrender'

function (g: zrender.Group) {
    g.eachChild((el: zrender.Displayable) => { /* do something */ })
}

@pissang pissang merged commit bb2ffb1 into ecomfe:master Sep 14, 2021
@baojd42 baojd42 deleted the fix-export-displayable branch September 15, 2021 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pissang pissang pissang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@baojd42 @pissang