fix(svg): clear text when mouse leaves #535
Conversation
|
The So if you remove it from the document when A better way to not display this text element is removing the |
|
@pissang But it has the same behavior with function removeOldTextNode(el) {
if (el && el.__textSvgEl) {
var children = el.__textSvgEl.children;
for (var i = 0; i < children.length; ++i) {
if (children[i]) {
el.__textSvgEl.removeChild(children[i]);
}
}
}
} |
|
It seems you need to reset more cached properties. function removeOldTextNode(el) {
if (el && el.__textSvgEl) {
el.__textSvgEl.parentNode.removeChild(el.__textSvgEl);
el.__textSvgEl = null;
el.__tspanList = [];
el.__text = null;
}
}Also the new created svg text dom needs to be add to document when updating the element in else if (!item.removed) {
for (var k = 0; k < item.count; k++) {
var displayable = newVisibleList[item.indices[k]];
var svgElement = getSvgElement(displayable);
var textSvgElement = getTextSvgElement(displayable);
this.gradientManager.markUsed(displayable);
this.gradientManager
.addWithoutUpdate(svgElement || textSvgElement, displayable);
this.shadowManager.markUsed(displayable);
this.shadowManager
.addWithoutUpdate(svgElement || textSvgElement, displayable);
this.clipPathManager.markUsed(displayable);
if (textSvgElement) { // Insert text.
insertAfter(svgRoot, textSvgElement, svgElement);
}
prevSvgElement = svgElement
|| textSvgElement || prevSvgElement;
} |
Ovilia
changed the title
Fix apache/echarts#11543 .
This commit can remove the text. But when the mouse hovers on the circle again, the text doesn't show up.