feat(color): support function for modifyHSL #1118
Merged
+13
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
100pah
requested changes
May 12, 2025
src/tool/color.ts
Outdated
| s != null && (colorArr[1] = | ||
| typeof s === 'function' | ||
| ? s(colorArr[1]) | ||
| : parseCssFloat(s) |
Contributor
There was a problem hiding this comment.
- Use
isFunctionto help with code compression. - If the input number
h,s,lare performed byparseCssFloatandclampCssAngle- especially the "clamp" logic inside of them.
the return of functionh,s,lshould also be processed by them,
otherwise the semantics of the API is inconsistent.
e.g.,
colorArr[0] = clampCssAngle( isFunction(h) ? h(colorArr[0]) : h)
colorArr[1] = isFunction(s) ? clampCssFloat(s(colorArr[1])) : parseCssFloat(s)
src/tool/color.ts
Outdated
| color: string, | ||
| h?: number | ((h: number) => number), | ||
| s?: number | ((s: number) => number), | ||
| l?: number | ((l: number) => number) |
Contributor
There was a problem hiding this comment.
The TS type of s and l is incorrect historically.
Could we correct them? Since we modify it this time.
s: string | number | ((s: number) => number) // accept css float like '30%' or float number like 0.3.
l: string | number | ((l: number) => number) // accept css float like '30%' or float number like 0.3.
100pah
approved these changes
May 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support function for modifyHSL so that we can calculate dark theme color in ECharts from light color.