fix(transform): fix invTransform may not be reset when updating transform
#1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
pissang
approved these changes
May 14, 2023
Ovilia
added a commit
that referenced
this pull request
Jan 23, 2024
Ovilia
added a commit
that referenced
this pull request
Jan 24, 2024
fix: fix lint problems and add ci workflow; invTransform NPE due to #1011
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves apache/echarts#18412. See apache/echarts#18625 for the test case.
When checking the hovering target, the
Transformable#transformCoordToLocalfunction will be used in theDisplayable#rectContainfunction.But in the
Transformable#updateTransformfunction, theinvTransformis not reset when thetransformis set to the identity matrix, which may result in a wrong local coordinate.