Skip to content

fix: save_metadata to support both multiple datasets with many arrays and old set up with no arrays#239

Merged
anaprietonem merged 5 commits intomainfrom
fix_write_supporting_arrays
Dec 8, 2025
Merged

fix: save_metadata to support both multiple datasets with many arrays and old set up with no arrays#239
anaprietonem merged 5 commits intomainfrom
fix_write_supporting_arrays

Conversation

@anaprietonem
Copy link
Copy Markdown
Collaborator

Description

Add test to write metadata with no arrays, and when arrays dict contains multiple entries (simulating multiple-dataset set up)

What problem does this change solve?

Previous changes broke support for old set ups where supporting arrays were not defined.

What issue or task does this change relate to?

Additional notes

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@github-project-automation github-project-automation bot moved this to To be triaged in Anemoi-dev Nov 27, 2025
@github-actions github-actions bot added the tests label Nov 27, 2025
@anaprietonem anaprietonem changed the title fix and tests fix: and tests Nov 27, 2025
@anaprietonem anaprietonem changed the title fix: and tests fix: save_metadata to support both multiple datasets with many arrays and old set up with no arrays Nov 27, 2025
HCookie
HCookie previously approved these changes Dec 2, 2025
@HCookie HCookie moved this from To be triaged to Under Review in Anemoi-dev Dec 4, 2025
@anaprietonem anaprietonem requested a review from HCookie December 5, 2025 16:31
Copy link
Copy Markdown
Member

@gmertes gmertes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HCookie HCookie moved this from Under Review to For merging in Anemoi-dev Dec 8, 2025
@anaprietonem anaprietonem merged commit b22444f into main Dec 8, 2025
69 checks passed
@github-project-automation github-project-automation bot moved this from For merging to Done in Anemoi-dev Dec 8, 2025
@anaprietonem anaprietonem deleted the fix_write_supporting_arrays branch December 8, 2025 14:22
floriankrb pushed a commit that referenced this pull request Jan 8, 2026
🤖 Automated Release PR

This PR was created by `release-please` to prepare the next release.
Once merged:

1. A new version tag will be created
2. A GitHub release will be published
3. The changelog will be updated

Changes to be included in the next release:
---


##
[0.4.41](0.4.40...0.4.41)
(2026-01-08)


### Features

* Fix argument type for transfer tool
([#253](#253))
([7d020d1](7d020d1))


### Bug Fixes

* Further improve typing on registry
([#249](#249))
([97c8874](97c8874))
* Save_metadata to support both multiple datasets with many arrays and
old set up with no arrays
([#239](#239))
([b22444f](b22444f))

---
> [!IMPORTANT]
> Please do not change the PR title, manifest file, or any other
automatically generated content in this PR unless you understand the
implications. Changes here can break the release process.
> ⚠️ Merging this PR will:
> - Create a new release
> - Trigger deployment pipelines
> - Update package versions

 **Before merging:**
 - Ensure all tests pass
 - Review the changelog carefully
 - Get required approvals

[Release-please
documentation](https://github.com/googleapis/release-please)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

save_metadata panics without supporting arrays

3 participants