This repository was archived by the owner on Dec 20, 2024. It is now read-only.
fix: use update_graph without attrs_cfg instead register_edges#85
Merged
fix: use update_graph without attrs_cfg instead register_edges#85
Conversation
fprill
approved these changes
Nov 26, 2024
Contributor
fprill
left a comment
fprill
left a comment
There was a problem hiding this comment.
Hello Mario, this works perfectly now. Thanks!
(This PR resolves the AttributeError: 'ICONTopologicalProcessorEdges' object has no attribute 'icon_sub_graph' which previously occurred because update_graph had not been called for the edge_builder)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the following issue:
Bug Description
When moving from a single edge builder to multiple edge builders, attribute normalization was moved to occur after all edge builders registered their nodes. Specifically, register_edges() was called for each edge builder, and register_attributes() was executed once after all edges were defined. This caused a problem: node builders extending update_graph (e.g., with type checking or additional functionality) were not being executed during graph creation.
Fix
To resolve this,
update_graph(graph, attrs_config=None)is now executed for each edge builder, ensuring expected behaviour during graph creation.