Skip to content
This repository was archived by the owner on Dec 20, 2024. It is now read-only.

Fix/deprecated config file#83

Merged
JPXKQX merged 5 commits intodevelopfrom
fix/deprecated-config-file
Nov 25, 2024
Merged

Fix/deprecated config file#83
JPXKQX merged 5 commits intodevelopfrom
fix/deprecated-config-file

Conversation

@JPXKQX
Copy link
Copy Markdown
Member

@JPXKQX JPXKQX commented Nov 24, 2024 •
edited
Loading

This PR fixes support for current versions of the config file which will be deprecated in future versions.

File ".../anemoi/anemoi-graphs/src/anemoi/graphs/create.py", line 69, in update_graph
    edge_builder_cfg.source_mask_attr_name = edges_cfg.get("source_mask_attr_name")
omegaconf.errors.ConfigAttributeError: Key 'source_mask_attr_name' is not in struct
    full_key: graph.edges[0].edge_builder.source_mask_attr_name
    object_type=dict

To test this PR, run anemoi-training using the latest develop branches.

floriankrb
floriankrb reviewed Nov 25, 2024
View reviewed changes
@JPXKQX JPXKQX requested a review from floriankrb November 25, 2024 09:07
@JPXKQX JPXKQX merged commit 2f53aae into develop Nov 25, 2024
@JPXKQX JPXKQX deleted the fix/deprecated-config-file branch December 16, 2024 15:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@floriankrb floriankrb floriankrb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

no changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JPXKQX @floriankrb