Skip to content

Support Macosx aarch64#28

Merged
planger merged 1 commit into
eclipsesource:masterfrom
hocesjc:feature/support-macox-aarch64
Jan 25, 2023
Merged

Support Macosx aarch64#28
planger merged 1 commit into
eclipsesource:masterfrom
hocesjc:feature/support-macox-aarch64

Conversation

@hocesjc

@hocesjc hocesjc commented Jan 25, 2023 •
edited by planger
Loading

Copy link
Copy Markdown
Contributor

Resolves #27

@planger planger self-requested a review January 25, 2023 11:13
planger
planger approved these changes Jan 25, 2023
View reviewed changes

@planger planger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Build works for me and changes look good.

I've added the built archive for MacOS aarch64 to https://github.com/eclipsesource/megit/releases/tag/v0.3.0. Can you please let me know if the built archive works for you?

@planger planger merged commit c7cfbda into eclipsesource:master Jan 25, 2023
@hocesjc

hocesjc commented Jan 25, 2023

Copy link
Copy Markdown
Contributor Author

It don't work says the same of #10

when i build it local in local it work ok.

@hocesjc

hocesjc commented Jan 25, 2023

Copy link
Copy Markdown
Contributor Author

image

@planger

planger commented Jan 25, 2023

Copy link
Copy Markdown
Collaborator

Hm, it looks like we need to run xattr after a build on the binaries for Mac. Does it work if you run sudo xattr -rd com.apple.quarantine ./Eclipse.app?

I guess we should consider building in a Github action and automate that, as it starts to involve some specific steps.

@hocesjc

hocesjc commented Jan 25, 2023

Copy link
Copy Markdown
Contributor Author

It work with sudo xattr -rd com.apple.quarantine ./Eclipse.app

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@planger planger planger approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build for Mac os Arm 64

2 participants

@hocesjc @planger