Fix ScopedObject cleanup for JUnit 5.9.x compatibility#156
Merged
tsegismont merged 1 commit intoeclipse-vertx:masterfrom Mar 24, 2026
Merged
Fix ScopedObject cleanup for JUnit 5.9.x compatibility#156tsegismont merged 1 commit intoeclipse-vertx:masterfrom
tsegismont merged 1 commit intoeclipse-vertx:masterfrom
Conversation
…#155) See eclipse-vertx#155 ScopedObject must implement both ExtensionContext.Store.CloseableResource and AutoCloseable to ensure proper cleanup across all JUnit 5.x versions. JUnit 5.9.x and earlier only recognize CloseableResource for automatic cleanup. Without it, ScopedObject.close() is never called, causing resources (Vertx instances, HTTP servers) to leak between test iterations. JUnit 5.11+ added AutoCloseable support, but we need both interfaces for backward compatibility with users on older JUnit versions. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
to tsegismont/vertx-junit5
that referenced
this pull request
Mar 24, 2026
…#155) (eclipse-vertx#156) See eclipse-vertx#155 ScopedObject must implement both ExtensionContext.Store.CloseableResource and AutoCloseable to ensure proper cleanup across all JUnit 5.x versions. JUnit 5.9.x and earlier only recognize CloseableResource for automatic cleanup. Without it, ScopedObject.close() is never called, causing resources (Vertx instances, HTTP servers) to leak between test iterations. JUnit 5.11+ added AutoCloseable support, but we need both interfaces for backward compatibility with users on older JUnit versions. Signed-off-by: Thomas Segismont <[email protected]>
tsegismont
added a commit
that referenced
this pull request
Mar 24, 2026
…157) See #155 ScopedObject must implement both ExtensionContext.Store.CloseableResource and AutoCloseable to ensure proper cleanup across all JUnit 5.x versions. JUnit 5.9.x and earlier only recognize CloseableResource for automatic cleanup. Without it, ScopedObject.close() is never called, causing resources (Vertx instances, HTTP servers) to leak between test iterations. JUnit 5.11+ added AutoCloseable support, but we need both interfaces for backward compatibility with users on older JUnit versions. Signed-off-by: Thomas Segismont <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #155
ScopedObject must implement both ExtensionContext.Store.CloseableResource and AutoCloseable to ensure proper cleanup across all JUnit 5.x versions.
JUnit 5.9.x and earlier only recognize CloseableResource for automatic cleanup. Without it, ScopedObject.close() is never called, causing resources (Vertx instances, HTTP servers) to leak between test iterations.
JUnit 5.11+ added AutoCloseable support, but we need both interfaces for backward compatibility with users on older JUnit versions.