Skip to content

jUnit 5.14.0 upgrade#145

Merged
tsegismont merged 2 commits intoeclipse-vertx:masterfrom
tsegismont:bump-5.14.0
Oct 14, 2025
Merged

jUnit 5.14.0 upgrade#145
tsegismont merged 2 commits intoeclipse-vertx:masterfrom
tsegismont:bump-5.14.0

Conversation

@tsegismont
Copy link
Copy Markdown
Member

Upgrade to latest version and deal with deprecations that lead to warning in user projects, such as:

Oct 07, 2025 6:43:24 PM org.junit.jupiter.engine.descriptor.AbstractExtensionContext lambda$createCloseAction$1 
WARNING: Type implements CloseableResource but not AutoCloseable: io.vertx.junit5.ScopedObject 

Signed-off-by: Thomas Segismont <[email protected]>
Signed-off-by: Thomas Segismont <[email protected]>
@tsegismont tsegismont added this to the 5.1.0 milestone Oct 14, 2025
@tsegismont tsegismont merged commit 1817021 into eclipse-vertx:master Oct 14, 2025
4 checks passed
@tsegismont tsegismont deleted the bump-5.14.0 branch October 14, 2025 13:00
@yeikel
Copy link
Copy Markdown

yeikel commented Jan 20, 2026

Any chance we can backport this to 4.x?

We are using the latest 4.x version but we are seeing

org.junit.jupiter.engine.descriptor.AbstractExtensionContext msg=Type implements CloseableResource but not AutoCloseable: io.vertx.junit5.ScopedObject   

@tsegismont
Copy link
Copy Markdown
Member Author

We could have the extension context extending AutoCloseable in 4.x. Would you mind sending a PR?

@yeikel
Copy link
Copy Markdown

yeikel commented Jan 20, 2026

org.junit.jupiter.engine.descriptor.AbstractExtensionContext msg=Type implements CloseableResource but not AutoCloseable: io.vertx.junit5.ScopedObject

I created #149

Thanks!

@tsegismont
Copy link
Copy Markdown
Member Author

@yeikel would you mind sending the same PR to the 5.0 branch please?

@yeikel
Copy link
Copy Markdown

yeikel commented Jan 20, 2026

@yeikel would you mind sending the same PR to the 5.0 branch please?

#150

For my own understanding, what is the difference between the 5.0 branch and master right now? I thought that master was tracking the 5.x version

Thanks!

@tsegismont
Copy link
Copy Markdown
Member Author

what is the difference between the 5.0 branch and master right now?

5.0 branch is the maintenance branch for 5.0.x relases. master branch gets developments for the next minor versionm that is5.1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants