Fix ScopedObject cleanup for JUnit 5.9.x compatibility (#155) (#156) (#157)

tsegismont · web-flow · commit 262f9e46d089 · 2026-03-24T17:50:17.000+01:00
See #155 ScopedObject must implement both ExtensionContext.Store.CloseableResource and AutoCloseable to ensure proper cleanup across all JUnit 5.x versions. JUnit 5.9.x and earlier only recognize CloseableResource for automatic cleanup. Without it, ScopedObject.close() is never called, causing resources (Vertx instances, HTTP servers) to leak between test iterations. JUnit 5.11+ added AutoCloseable support, but we need both interfaces for backward compatibility with users on older JUnit versions. Signed-off-by: Thomas Segismont <tsegismont@gmail.com>
diff --git a/src/main/java/io/vertx/junit5/ScopedObject.java b/src/main/java/io/vertx/junit5/ScopedObject.java
@@ -16,6 +16,8 @@
 
 package io.vertx.junit5;
 
+import org.junit.jupiter.api.extension.ExtensionContext;
+
 import java.util.Objects;
 import java.util.function.Supplier;
 
@@ -27,7 +29,7 @@
  * @param <T> Parameter type
  * @author <a href="https://julien.ponge.org/">Julien Ponge</a>
  */
-public class ScopedObject<T> implements Supplier<T>, AutoCloseable  {
+public class ScopedObject<T> implements Supplier<T>, ExtensionContext.Store.CloseableResource, AutoCloseable {
 
   private T object;
   private final ParameterClosingConsumer<T> cleaner;
