Set bigger DTLS_MAX_BUF for Contiki/RIOT#19
Merged
obgm merged 1 commit intoeclipse-tinydtls:developfrom Oct 2, 2019
Merged
Conversation
Contributor
|
Thanks, you are correct that this buffer size is somewhat small. Please sign the Eclipse ECA so I can merge your change. |
Contributor
Author
|
Signed the Eclipse ECA. |
Contributor
|
Oh, and the Eclipse policies also require that you add the Signed-off-by footer with the ECA-signed email address to the commit message (usually by running |
Signed-off-by: pokgak <[email protected]>
pokgak
force-pushed
the
pr/bigger_dtls_max_buf
branch
from
02b8aa2 to
865ca38
Compare
Contributor
Author
|
Added Signed-by footer :) |
This was referenced Oct 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of a server in RIOT built with only PSK support when an ECC client sends a second ClientHello to it.
Problem
The server does not return
handshake_failureas described in the 4th paragraph Section 7.4.1.2 of TLS 1.2 RFC because receiving buffer has a size ofDTLS_MAX_BUFwhich is too small to receive a ClientHello from an ECC client.Testing
A step-by-step guide reproducing this issue on RIOT is described in RIOT-OS/RIOT#12351. I tested by applying this patch after commit dcac93 which is the current version used in RIOT.
I cannot test this with the latest develop because there is error when using latest commit on develop on RIOT but I don't think it is related to this PR.