Upgrade to TypeScript 5.x #1343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1343 +/- ##
==========================================
- Coverage 78.56% 77.73% -0.83%
==========================================
Files 83 83
Lines 16587 16588 +1
Branches 1613 1609 -4
==========================================
- Hits 13031 12895 -136
- Misses 3532 3662 +130
- Partials 24 31 +7 ☔ View full report in Codecov by Sentry. |
Member
Author
|
About coap issue, I've opened a PR there: coapjs/node-coap#392 |
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
Thanks @relu91 👍.
The changes look good, I have just one comment...
Member
I just released a new patch release 1.4.1 containing the changes from coapjs/node-coap#392 that should resolve this aspect :) |
Member
Author
|
Just upgraded coap too. Everything should be ready to be merged, @danielpeintner . |
JKRhb
approved these changes
Jan 21, 2025
danielpeintner
approved these changes
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final step of the work, which started a few months ago, to renovate the whole toolchain and build targets of node-wot. This PR focuses on upgrading to the latest typescript stable version. Main points: