Move to es2021 #1340
Merged
Move to es2021 #1340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
- Coverage 77.61% 77.37% -0.25%
==========================================
Files 83 83
Lines 16576 16587 +11
Branches 1640 1589 -51
==========================================
- Hits 12866 12834 -32
- Misses 3652 3729 +77
+ Partials 58 24 -34 ☔ View full report in Codecov by Sentry. |
danielpeintner
approved these changes
Dec 16, 2024
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
It looks everything seems to work 👍
Maybe we can remove the statement here
as part of this PR
Member
Author
|
Should I also update the examples if needed? |
danielpeintner
approved these changes
Dec 17, 2024
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
Looks good 👍
In a follow-up, we might want to get rid of the whole workflow
node-wot/packages/examples/README.md
Lines 14 to 29 in 5afa858
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #1267 we decided to move to a more modern js target. After #1336 everything goes pretty smooth, I'll double check next week if there is anything more to do (or please just comment below if you know more).