refactor: Use interface for WoT.consume() #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Interesting that CI fails for "version consistency" ... I didn't even touch anything related |
danielpeintner
changed the title
relu91
approved these changes
Nov 8, 2024
Member
relu91
left a comment
relu91
left a comment
There was a problem hiding this comment.
Technically this is a change of the interface... therefore we should publish a minor next. The changes are fine, I appreciate the fact that we are now consistent. Weird that the CI broke even if you didn't introduce any new dep.
danielpeintner
added a commit
to danielpeintner/thingweb.node-wot
that referenced
this pull request
Jan 29, 2025
Minor version change needed due to eclipse-thingweb#1332
danielpeintner
added a commit
that referenced
this pull request
Jan 31, 2025
Minor version change needed due to #1332
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1331