Skip to content

Conversation

@danielpeintner
Copy link
Member

Note: I used the exact same version for is-absolute-url and url-toolkit as in

"is-absolute-url": "3.0.3",
"json-placeholder-replacer": "^1.0.35",
"url-toolkit": "2.1.6",
to avoid issues.

fixes #1317

@danielpeintner
Copy link
Member Author

I also wonder if this justifies a quick new release, because the library is not really usable without the fix, right ...

@hasanheroglu ?

@JKRhb
Copy link
Member

JKRhb commented Aug 21, 2024

I also wonder if this justifies a quick new release, because the library is not really usable without the fix, right ...

I think that would make sense :)

@hasanheroglu
Copy link
Contributor

I also wonder if this justifies a quick new release, because the library is not really usable without the fix, right ...

@hasanheroglu ?

As a workaround, one can install the missing dependencies separately, but yes the library is broken.

@danielpeintner
Copy link
Member Author

@relu91 are you fine with releasing an update ASAP ?

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely ok for releasing

@relu91 relu91 merged commit 04b7636 into eclipse-thingweb:master Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

core package is missing dependencies in v0.8.15

4 participants