fix(core/interactionOutput): support for no-type based root schemas #1309
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1309 +/- ##
==========================================
- Coverage 76.75% 76.26% -0.49%
==========================================
Files 83 82 -1
Lines 16058 15946 -112
Branches 1621 1603 -18
==========================================
- Hits 12325 12162 -163
- Misses 3678 3731 +53
+ Partials 55 53 -2 ☔ View full report in Codecov by Sentry. |
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
Looks good.
Question: How can we proceed with the other schema combinations like allOf, anyOf and not ?
I had the same question, but I preferred to stick with what was in the Scripting API spec. I think we can easily fix it there and then add them in node-wot later. |
|
given @danielpeintner 's approval, I'm merging this. |
|
I can confirm this works! |
3 participants
As discussed in #1243 and solved in w3c/wot-scripting-api#534, we now allow more root schema types to be accepted in the value function. The validation still happens but it supports:
const,enum, andoneOf. Those terms can now be used instead oftype. The behavior of using these terms at the same time is delegated to Ajv.validate function.