Upgrade dependencies, skip mbus tests under Windows, use Node 22 in CI#1302
Merged
danielpeintner merged 8 commits intoeclipse-thingweb:masterfrom Jul 11, 2024
Merged
Conversation
Co-Authored-By: Jan Romann <[email protected]>
JKRhb
force-pushed
the
dependency-upgrade-mbus-skip
branch
from
460bef7 to
4a4a31f
Compare
relu91
approved these changes
Jul 11, 2024
Member
relu91
left a comment
relu91
left a comment
There was a problem hiding this comment.
Thank you Jan! I think this is the best way forward. At least it unblocks us and we can continue the development!
danielpeintner
approved these changes
Jul 11, 2024
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
LGTM
Usually I like to "separate" concerns.
Anyhow, maybe in this case it is time to be pragmatic and to move on 🙃
Thank you Jan!
Member
|
FYI: I created #1303 to keep track of the mbus problem |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR combines some of the changes also present in the PRs #1297 and #1274 to partially resolve the failing tests we are currently experiencing by upgrading some of the dependencies and skipping the Mbus tests in the CI under Windows. It also adds Node 22 to the CI matrix.
If this PR should get merged, we should probably create a follow-up issue for continuing the work on resolving the Mbus problem.
Closes #1297, closes #1274, closes #1292.