Support for default accept header in http client #1283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This Thing has behavior implementation to test this:https://github.com/eclipse-thingweb/test-things/tree/main/things/calculator/http/express |
danielpeintner
approved these changes
May 9, 2024
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
LGTM.
One minor suggestion
Co-authored-by: danielpeintner <[email protected]>
Member
Author
|
Given @egekorkan's comment, I think we should merge this after someone has tried to interact with the mentioned Thing. I don't have time today so if anybody else wants to test these changes please feel free to report it here. |
egekorkan
approved these changes
May 10, 2024
Member
egekorkan
left a comment
egekorkan
left a comment
There was a problem hiding this comment.
I have just tested and it works as expected. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #854 this PR adds the default assumptions for the Accept header when interacting with a remote Thing. It also assumes that if the user provides the headers field his choice has preference over the default assumptions.