refactor(binding-mqtt/mqtt-broker-server): move listening to start method #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thod Listening is an asynchronous interaction that might throw an error. It's better to defer it until we start the server. This should help also debugging possible errors when listening.
Member
Author
|
Related to #1159 |
egekorkan
approved these changes
Apr 24, 2024
danielpeintner
approved these changes
Apr 24, 2024
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
LGTM
The CI seemed to work right away in the current CI build
Member
|
Note: Might fix/close #1159 |
Member
Author
|
The second run got all green lights again: https://github.com/eclipse-thingweb/node-wot/actions/runs/8818248577 . Let's wait a couple more iterations than I think we can finally close #1159 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listening is an asynchronous interaction that might throw an error. It's better to defer it until we start the server. This should help also debug possible errors when listening. Let's see if it stabilizes a little bit the CI errors.