Skip to content

refactor: report undefined for no expected value() #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielpeintner merged 8 commits into from
Feb 22, 2024
Merged

refactor: report undefined for no expected value() #1230

danielpeintner merged 8 commits into from
Feb 22, 2024

Conversation

@danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Feb 9, 2024

fixes #1228

@danielpeintner danielpeintner marked this pull request as draft February 9, 2024 09:14
@danielpeintner danielpeintner mentioned this pull request Feb 9, 2024
Closed
JKRhb
JKRhb reviewed Feb 12, 2024
View reviewed changes
@danielpeintner
Copy link
Member Author

danielpeintner commented Feb 13, 2024

We have a failing test

https://github.com/eclipse-thingweb/node-wot/actions/runs/7889804138/job/21530521048#step:9:198

should throw if the stream was accessed before calling value

@relu91 mhh not sure if the test does the correct thing in this case

@danielpeintner
Copy link
Member Author

danielpeintner commented Feb 14, 2024

We have a failing test

I fixed the test by adding a DataSchema which is now required, see 051febc

@codecov
Copy link

codecov bot commented Feb 14, 2024 •
edited
Loading

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (82f7f7a) 77.77% compared to head (be93623) 77.80%.
Report is 14 commits behind head on master.

Files Patch % Lines
packages/core/src/interaction-output.ts 90.90% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1230      +/-   ##
==========================================
+ Coverage   77.77%   77.80%   +0.03%     
==========================================
  Files          84       84              
  Lines       17476    17492      +16     
  Branches     1770     1773       +3     
==========================================
+ Hits        13592    13610      +18     
+ Misses       3848     3846       -2     
  Partials       36       36

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielpeintner danielpeintner marked this pull request as ready for review February 14, 2024 09:11
danielpeintner
danielpeintner commented Feb 14, 2024
View reviewed changes
@danielpeintner danielpeintner mentioned this pull request Feb 16, 2024
Open
danielpeintner
danielpeintner commented Feb 20, 2024
View reviewed changes
relu91
relu91 approved these changes Feb 21, 2024
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @danielpeintner and sorry for being a little bit stubborn on this issue :)

@danielpeintner danielpeintner mentioned this pull request Feb 21, 2024
Closed
@danielpeintner danielpeintner merged commit ad76c37 into eclipse-thingweb:master Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@relu91 relu91 relu91 approved these changes

@JKRhb JKRhb JKRhb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

InteractionOutput.value() throws an error for Actions with no output DataSchema

3 participants

@danielpeintner @relu91 @JKRhb