fix(octet-stream): correct limits for integer serialization and add tests #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derwehr
requested review from
JKRhb,
danielpeintner and
relu91
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1219 +/- ##
==========================================
+ Coverage 77.75% 77.77% +0.02%
==========================================
Files 84 84
Lines 17444 17452 +8
Branches 1765 1766 +1
==========================================
+ Hits 13564 13574 +10
+ Misses 3844 3842 -2
Partials 36 36 ☔ View full report in Codecov by Sentry. |
danielpeintner
approved these changes
Jan 23, 2024
Member
|
I noticed that there is a style check issue. Can you run |
Member
relu91
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the limits for integer serialization are wrong and corrected them. Additionally, I added test for these limits.
Changes in
octetstream-codec.ts255as unsigned integer with 8 bits failed, succeeds now;127as signed integer with 8 bits failed, succeeds new;Changes in
ContentSerdesTest.ts255asuint8,127and-128asint8succeed256and-1asunit8,128and-129asint8fail