fix(binding-file): improve file-client implementation #1213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1213 +/- ##
==========================================
- Coverage 77.60% 77.60% -0.01%
==========================================
Files 83 83
Lines 17311 17309 -2
Branches 1747 1747
==========================================
- Hits 13435 13433 -2
Misses 3840 3840
Partials 36 36 ☔ View full report in Codecov by Sentry. |
relu91
approved these changes
Jan 9, 2024
Member
relu91
left a comment
relu91
left a comment
There was a problem hiding this comment.
Tested also locally, good to go.
danielpeintner
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to make the file-client implementation more reliable by replacing the synchronous
fscode with asynchronous alternatives fromfs/promises. I am not sure how much of a difference this will make, but I hope this change will resolve the issues we have been observing since the merging of #1175.