Follow-up octet-stream codec - short explanation #1194 #1209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1209 +/- ##
==========================================
- Coverage 77.60% 77.56% -0.05%
==========================================
Files 83 83
Lines 17311 17311
Branches 1747 1747
==========================================
- Hits 13434 13427 -7
- Misses 3841 3849 +8
+ Partials 36 35 -1 ☔ View full report in Codecov by Sentry. |
JKRhb
approved these changes
Jan 7, 2024
Member
JKRhb
left a comment
JKRhb
left a comment
There was a problem hiding this comment.
The following suggestions can be applied to get rid of the prettier errors – otherwise LGTM :)
Contributor
Author
Thanks for the review. I commited the suggested changes |
Co-authored-by: danielpeintner <[email protected]>
relu91
approved these changes
Jan 8, 2024
Member
relu91
left a comment
relu91
left a comment
There was a problem hiding this comment.
Thank you! good to go from my side.
danielpeintner
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added descriptions for the content type parameters and data schema terms of the
octet-streamcodec, and an example of how to describe an object with the new terms.(related issue: #1194)