ci: enable logging only when debug logging is enabled #1204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1204 +/- ##
==========================================
- Coverage 77.44% 75.93% -1.51%
==========================================
Files 82 83 +1
Lines 17241 17311 +70
Branches 1737 1742 +5
==========================================
- Hits 13352 13145 -207
- Misses 3854 4109 +255
- Partials 35 57 +22 ☔ View full report in Codecov by Sentry. |
|
A demonstration of a run with debug logging enabled can be found here: https://github.com/eclipse-thingweb/node-wot/actions/runs/7287753854/job/19859204326 |
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
I think the change/simplification makes sense.
Below a "request" ;-)
| sudo echo "127.0.0.1" `hostname` | sudo tee -a /etc/hosts | ||
| - name: Configure debug logging | ||
| if: runner.debug == '1' |
There was a problem hiding this comment.
I think it makes sense to describe what this flag is and how it can be enabled...
Not sure if some prose in ci.yaml makes sense or also pointing to this PR where one could see the GH screenshot etc
OR maybe both?
relu91
left a comment
relu91
left a comment
There was a problem hiding this comment.
Great! I discovered the option while we were debuggin MQTT and I didn't think we could exploit like this. Awesome! It is going still hard to catch that nasty MQTT problem but nonetheless I'd go on and merge the PR after @danielpeintner's concerns are resolved.
3 participants
In the menu for rerunning failed actions, I noticed that there is an option for "enabling debug logging" as can be seen in this screenshot:
Although we have introduced automatic reruns with debug logging in #1189, I got the impression that this change is not that well usable in practice, partly because it makes the logs for failed actions very long, thereby increasing the difficulty of finding the place where something went wrong.
This PR proposes using debug logging only when it is enabled via the GitHub actions UI that can be seen above, making the choice of seeing the verbose output a bit more deliberate. This change would also half the wait time for feedback on a failed test while getting rid of the external dependency introduced for retrying the tests automatically.