test(binding-file): use asynchronous unlink for file deletion #1185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
==========================================
+ Coverage 75.33% 76.66% +1.33%
==========================================
Files 80 80
Lines 16813 16813
Branches 1614 1618 +4
==========================================
+ Hits 12666 12890 +224
+ Misses 4100 3893 -207
+ Partials 47 30 -17 ☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
file-client-fix
branch
from
ede1cf4 to
92ae1fa
Compare
Member
Author
|
The file client tests seem to run more reliably now :) Thanks @relu91 for the hint regarding the asynchronous |
Member
Author
|
The only thing left failing sometimes is the MQTT tests now but that should be resolved by #1184 – which PR should we merge first? |
relu91
approved these changes
Dec 7, 2023
Member
relu91
left a comment
relu91
left a comment
There was a problem hiding this comment.
Let's go with this if @danielpeintner is also ok.
danielpeintner
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR might resolve the issues we've been observing with the file client tests.