Skip to content

Conversation

@danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Nov 20, 2023

Note: adds empty discovery methods:

  • discover(...)
  • exploreDirectory(...)
  • requestThingDescription(...)

@codecov
Copy link

codecov bot commented Nov 20, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (49546bc) 76.67% compared to head (9a55bd2) 76.67%.

Files Patch % Lines
packages/core/src/wot-impl.ts 54.54% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1165   +/-   ##
=======================================
  Coverage   76.67%   76.67%           
=======================================
  Files          80       80           
  Lines       16661    16625   -36     
  Branches     1604     1603    -1     
=======================================
- Hits        12774    12748   -26     
+ Misses       3857     3847   -10     
  Partials       30       30           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @danielpeintner! :) After merging, I will incorporate the changes into #864 which should then be ready for an initial review soon.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great thank you Daniel! let's go :)

@relu91 relu91 merged commit a494687 into eclipse-thingweb:master Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants