refactor: enable strict-boolean-expressions globally #1127
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
- Coverage 77.17% 77.15% -0.03%
==========================================
Files 80 80
Lines 16245 16246 +1
Branches 1531 1535 +4
==========================================
- Hits 12537 12534 -3
- Misses 3685 3689 +4
Partials 23 23
☔ View full report in Codecov by Sentry. |
JKRhb
requested review from
danielpeintner,
egekorkan,
relu91 and
sebastiankb
as code owners
danielpeintner
approved these changes
Oct 18, 2023
Member
danielpeintner
left a comment
danielpeintner
left a comment
There was a problem hiding this comment.
That's a great clean-up! 🎉
relu91
reviewed
Oct 19, 2023
Co-authored-by: Cristiano Aguzzi <[email protected]>
Member
Author
|
(Performed a rebase against master which removed the commit from #1126 from the diff). |
Member
Author
|
Applied a last tiny improvement in 10f9498 – hopefully, this one is now good to go :) |
relu91
reviewed
Oct 19, 2023
relu91
reviewed
Oct 19, 2023
Co-authored-by: Cristiano Aguzzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1126, resolves #1046.