Skip to content

Conversation

@egekorkan
Copy link
Member

Extending the readme with the other online Things we have. For the CG tutorial, we have stored the TDs in Zion and I am doing the same here but we can discuss that if needed. The reason for that was that we needed somewhere to store the MQTT TD. Alternatives could be:

  • Storing the TDs in this GitHub
  • Storing them at domus-directory when it is here

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (b1d11a0) 77.12% compared to head (bd4d711) 77.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1124   +/-   ##
=======================================
  Coverage   77.12%   77.12%           
=======================================
  Files          80       80           
  Lines       16159    16159           
  Branches     1523     1523           
=======================================
  Hits        12463    12463           
  Misses       3675     3675           
  Partials       21       21           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go! I would keep them inside a TDD.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielpeintner danielpeintner merged commit e7e8fc7 into master Oct 16, 2023
@egekorkan egekorkan deleted the egekorkan-online-things-quickstart branch March 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants