Skip to content

fix: enable prefer-nullish-coalescing eslint rule #1123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
danielpeintner merged 1 commit into from
Oct 16, 2023
Merged

fix: enable prefer-nullish-coalescing eslint rule #1123

danielpeintner merged 1 commit into from
Oct 16, 2023

Conversation

@JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 13, 2023

Actually completely resolves #1092.

@codecov
Copy link

codecov bot commented Oct 13, 2023 •
edited
Loading

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (2e6fc09) 75.67% compared to head (f0729ab) 75.93%.
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1123      +/-   ##
==========================================
+ Coverage   75.67%   75.93%   +0.26%     
==========================================
  Files          80       80              
  Lines       16159    16159              
  Branches     1519     1515       -4     
==========================================
+ Hits        12228    12271      +43     
+ Misses       3889     3846      -43     
  Partials       42       42
Files Coverage Δ
packages/binding-mbus/src/mbus-client.ts 82.31% <100.00%> (+15.64%) ⬆️
packages/binding-modbus/src/modbus-client.ts 86.77% <100.00%> (ø)
packages/core/src/codecs/text-codec.ts 63.54% <100.00%> (ø)
packages/td-tools/src/thing-model-helpers.ts 84.41% <100.00%> (ø)
packages/binding-netconf/src/netconf-client.ts 76.66% <0.00%> (+11.11%) ⬆️
...ackages/binding-opcua/src/opcua-protocol-client.ts 79.74% <16.66%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

relu91
relu91 approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, good to go.

@danielpeintner danielpeintner merged commit 595d818 into eclipse-thingweb:master Oct 16, 2023
@JKRhb JKRhb deleted the nullish-coalescing branch October 16, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@relu91 relu91 relu91 approved these changes

@danielpeintner danielpeintner danielpeintner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable prefer-nullish-coalescing eslint rule

3 participants

@JKRhb @relu91 @danielpeintner