Skip to content

Conversation

@JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 13, 2023

This PR contains the changes from #1116 without limiting the workflow runs to the master branch, greatly simplifying the workflow file.

Closes #1116, closes #882.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

All modified lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@b44448b). Click here to learn what that means.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #1121   +/-   ##
=========================================
  Coverage          ?   77.30%           
=========================================
  Files             ?       80           
  Lines             ?    16159           
  Branches          ?     1524           
=========================================
  Hits              ?    12492           
  Misses            ?     3644           
  Partials          ?       23           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's go :)

@relu91 relu91 merged commit a5857b6 into eclipse-thingweb:master Oct 15, 2023
@JKRhb JKRhb deleted the ci-full branch October 15, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Try to get back all Os's for testing + firestore

3 participants