refactor: use structuredClone for deep copying
#1105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JKRhb
changed the title
structuredClone for deep coypingstructuredClone for deep copying
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1105 +/- ##
==========================================
+ Coverage 75.52% 75.54% +0.01%
==========================================
Files 80 80
Lines 16153 16162 +9
Branches 1520 1513 -7
==========================================
+ Hits 12200 12209 +9
Misses 3914 3914
Partials 39 39
☔ View full report in Codecov by Sentry. |
JKRhb
commented
Oct 3, 2023
| */ | ||
| static createExposeThingInitSchema(tdSchema: unknown): SomeJSONSchema { | ||
| const tdSchemaCopy = JSON.parse(JSON.stringify(tdSchema)); | ||
| const tdSchemaCopy = structuredClone(tdSchema) as SomeJSONSchema; |
Member
Author
There was a problem hiding this comment.
I added this as another instance suitable for using the structuredClone function – the typing is not that nice here, but I think casting should be fine here since we are performing type checks down below.
Member
There was a problem hiding this comment.
I guess it is acceptable, we could even put it as the argument type given the fact that is just an internal helper function
danielpeintner
approved these changes
Oct 11, 2023
This was referenced Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript nowadays has a built-in function for deep-cloning called
structuredClonewhich makes it possible to get rid of theJSON.parse(JSON.stringify(foo))construction. I found a few places where the new function can be used, hopefully increasing readability and performance a bit.Cases where the parse-stringify-approach still needs to be used could be revisited in the future to arrive at a slightly cleaner implementation.