fix(td-tools): proper absoluteURL handling in AAS/AID #1100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpeintner
commented
Sep 28, 2023
| expect(tdObj.properties.device_name.forms[0]).to.have.property("op").to.eql("readproperty"); | ||
| expect(tdObj.properties.device_name.forms[0]) | ||
| .to.have.property("href") | ||
| .to.eql("modbus+tcp://192.168.178.146:502/1/40020?quantity=16"); |
Member
Author
There was a problem hiding this comment.
Note: This is the actual issue that has been fixed and is tested now...
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1100 +/- ##
==========================================
+ Coverage 75.50% 75.52% +0.02%
==========================================
Files 80 80
Lines 16150 16153 +3
Branches 1517 1520 +3
==========================================
+ Hits 12194 12200 +6
+ Misses 3917 3914 -3
Partials 39 39
☔ View full report in Codecov by Sentry. |
sebastiankb
approved these changes
Sep 29, 2023
relu91
approved these changes
Sep 30, 2023
Member
relu91
left a comment
relu91
left a comment
There was a problem hiding this comment.
Thank you for providing a unit test too!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes issues with combination of
baseand abolsuteURL inhref.Added according (Modbus) test.