Codecov Report

Patch coverage: 72.72% and no project coverage change.

Comparison is base (227be53) 75.31% compared to head (fd72a5d) 75.32%.

@@           Coverage Diff           @@
##           master    #1088   +/-   ##
=======================================
  Coverage   75.31%   75.32%           
=======================================
  Files          80       80           
  Lines       16060    16057    -3     
  Branches     1503     1503           
=======================================
- Hits        12096    12095    -1     
+ Misses       3925     3923    -2     
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I still didn't have proper time to review this, I want to be sure that is sufficient for check only for null and not for undefined. Given that in TS/JS world is way more common to leave values into the undefined state, I would like to be careful to only check for null

I still didn't have proper time to review this, I want to be sure that is sufficient for check only for null and not for undefined. Given that in TS/JS world is way more common to leave values into the undefined state, I would like to be careful to only check for null

foo != null is basically a shorthand for foo !== null && foo !== undefined – as mentioned elsewhere, this is apparently the only case where using the == operator is valid. So when checking for null this way, you get the check for undefined for free and vice versa. (Having both null and undefined has obviously not been a good language design decision 😅).

I haven't found a really good documentation link to point here, but some further explanations can be found here: https://basarat.gitbook.io/typescript/recap/null-undefined#checking-for-either