Data Schema Fix for Quickstart example #1083
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relu91
approved these changes
Sep 14, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #1083 +/- ##
=======================================
Coverage 75.35% 75.35%
=======================================
Files 80 80
Lines 16083 16083
Branches 1503 1503
=======================================
Hits 12119 12119
Misses 3925 3925
Partials 39 39 ☔ View full report in Codecov by Sentry. |
danielpeintner
approved these changes
Sep 14, 2023
Comment on lines
+1
to
+2
| # Quick Start Things | ||
|
|
Member
There was a problem hiding this comment.
Does it make sense to link to the possible consumer part?
https://github.com/w3c/wot-cg/tree/main/Tutorials/quickstart
Member
Author
There was a problem hiding this comment.
I want to create it in ts and submit here but as a separate PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discovered in W3C TPAC, we should fix the TD Data Schema otherwise error is returned with property read