Skip to content

Conversation

@danielpeintner
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (03751a9) 75.28% compared to head (1751df8) 75.28%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   75.28%   75.28%           
=======================================
  Files          80       80           
  Lines       16070    16070           
  Branches     1503     1503           
=======================================
  Hits        12099    12099           
  Misses       3932     3932           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@JKRhb JKRhb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me in general :) However, there are a lot of changes to package-lock.json file for some reason – I suppose these are caused by updates to packages within the semantic versioning ranges, right?

@danielpeintner
Copy link
Member Author

However, there are a lot of changes to package-lock.json file for some reason – I suppose these are caused by updates to packages within the semantic versioning ranges, right?

Yes, once we prepare for a new release we update the dependencies too..

see https://github.com/eclipse-thingweb/node-wot#development-internals
image

To be honest, I think it is good to update the dependencies from time to time..
Do you think this should be done differently?

@danielpeintner danielpeintner merged commit 2b5be1f into eclipse-thingweb:master Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants