Skip to content

API Filters on Mac #1109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Phillipus wants to merge 1 commit into from
Closed

API Filters on Mac #1109

Phillipus wants to merge 1 commit into from

Conversation

@Phillipus
Copy link
Contributor

@Phillipus Phillipus commented Mar 13, 2024

API filters

@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

Test Results

   299 files  ±0     299 suites  ±0   6m 29s ⏱️ - 1m 23s
 4 099 tests ±0   4 091 ✅ ±0   8 💤 ±0  0 ❌ ±0 
12 209 runs  ±0  12 134 ✅ ±0  75 💤 ±0  0 ❌ ±0 

Results for commit 0465f88. ± Comparison against base commit a98c844.

♻️ This comment has been updated with latest results.

iloveeclipse
iloveeclipse requested changes Mar 13, 2024
View reviewed changes
binaries/org.eclipse.swt.cocoa.macosx.aarch64/.settings/.api_filters Outdated
<resource path="Eclipse SWT/emulated/tooltip/org/eclipse/swt/widgets/ToolTip.java" type="org.eclipse.swt.widgets.ToolTip">
<filter id="336744520">
<message_arguments>
<message_argument value="@noextend"/>
Copy link
Member

@iloveeclipse iloveeclipse Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you are using older IDE build.
Please use https://download.eclipse.org/eclipse/downloads/drops4/I20240311-1800/ for your IDE

Copy link
Contributor Author

@Phillipus Phillipus Mar 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use https://download.eclipse.org/eclipse/downloads/drops4/I20240311-1800/ for your IDE

And the baseline should be 4.31 RC2?

Copy link
Member

@iloveeclipse iloveeclipse Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The baseline should be 4.31 RC, but the IDE you are using should be https://download.eclipse.org/eclipse/downloads/drops4/I20240311-1800/ because of eclipse-pde/eclipse.pde#1187

Copy link
Member

@iloveeclipse iloveeclipse Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW you can use fresh https://download.eclipse.org/eclipse/downloads/drops4/I20240313-0830/ if you like.

Copy link
Contributor Author

@Phillipus Phillipus Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on it...

Copy link
Contributor Author

@Phillipus Phillipus Mar 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New one force pushed. This time there were no API errors, only warnings.

@iloveeclipse iloveeclipse mentioned this pull request Mar 13, 2024
Merged
@HannesWell
Copy link
Member

HannesWell commented Mar 13, 2024 •
edited
Loading

Thanks @Phillipus for helping on this one!
But I have just created a PR with an alternative approach since all the issues I saw are actually not real issues but only incomplete tagging (or API-tools being too strict IMHO).
Please see #1111.

Also did you know that you can easily check the API for other platforms. Just open the fragment for the corresponding platform+arch in your workspace and set the environment of your active target and the baseline target:
grafik

After a clean+full-build you should get the issues of that platform+arch.
I created #1111 on my Windows computer using that approach.

@Phillipus it would be great if you could confirm all I have done is right and there are no more API issues for the mac fragments.

@HannesWell
Copy link
Member

HannesWell commented Mar 14, 2024

@iloveeclipse and @Phillipus do you have a preference between this PR and #1111?

It would be great to have the API issues fixed in Mac to be able to complete #1110.

@iloveeclipse
Copy link
Member

iloveeclipse commented Mar 14, 2024

I had no time today, may be tomorrow I can look.

@Phillipus
Copy link
Contributor Author

Phillipus commented Mar 14, 2024

@iloveeclipse and @Phillipus do you have a preference between this PR and #1111?

It would be great to have the API issues fixed in Mac to be able to complete #1110.

@HannesWell I'm by no means knowledgable on this API stuff. I only put this PR here as a means to upload the filter file as instructed by @iloveeclipse I think it would be better to go with #1111 as it's from someone who knows what they're doing. ;-)

@HannesWell
Copy link
Member

HannesWell commented Mar 14, 2024

I had no time today, may be tomorrow I can look.

That would be great.

@iloveeclipse and @Phillipus do you have a preference between this PR and #1111?

It would be great to have the API issues fixed in Mac to be able to complete #1110.

@HannesWell I'm by no means knowledgable on this API stuff. I only put this PR here as a means to upload the filter file as instructed by @iloveeclipse I think it would be better to go with #1111 as it's from someone who knows what they're doing. ;-)

Thanks for the flowers. :)
Could you nevertheless try out #1111 on a real Mac and report if the are any warnings/errors left? Just to verify my changed setup on Windows worked?

@Phillipus
Copy link
Contributor Author

Phillipus commented Mar 14, 2024

Could you nevertheless try out #1111 on a real Mac and report if the are any warnings/errors left? Just to verify my changed setup on Windows worked?

Sure, but my problem is how? What version IDE do I need and what target to set?

@Phillipus
Copy link
Contributor Author

Phillipus commented Mar 14, 2024 •
edited
Loading

@HannesWell Actually I figured it out. I downloaded the latest I-build to use as IDE and set the API baseline to a separat 4.31 download. I merged your PR into SWT and....absolutely zero API errors or warnings. :-)

@HannesWell
Copy link
Member

HannesWell commented Mar 14, 2024

@HannesWell Actually I figured it out. I downloaded the latest I-build to use as IDE and set the API baseline to a separat 4.31 download. I merged your PR into SWT and....absolutely zero API errors or warnings. :-)

Perfect, thank you!

@HannesWell HannesWell mentioned this pull request Mar 14, 2024
Merged
@Phillipus
Copy link
Contributor Author

Phillipus commented Mar 14, 2024

Shall we close this one, I think it's not needed now?

@HannesWell
Copy link
Member

HannesWell commented Mar 14, 2024

Shall we close this one, I think it's not needed now?

Lets give Andrey some more time to review and add his preference. We can still close this tomorrow :)

@HannesWell
Copy link
Member

HannesWell commented Mar 15, 2024

Shall we close this one, I think it's not needed now?

Now that #1111 is submitted, lets close this one.

@HannesWell HannesWell closed this Mar 15, 2024
@Phillipus Phillipus deleted the api-filter branch March 15, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iloveeclipse iloveeclipse iloveeclipse requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Phillipus @HannesWell @iloveeclipse