Conversation
gnugomez
reviewed
Jun 23, 2026
gnugomez
approved these changes
Jun 23, 2026
This was referenced Jun 23, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, when files within extensions were served from various endpoints, the content type was deduced from the file type without any explicit security measure.
This could lead to XSS attacks.
This PR does the following:
The following protections are added:
X-Content-Type-Options: nosniffto prevent browsers from guessing the content typeContent-Security-Policywhen serving user controlled inputContent-Type: text/plainfor certain files whose source can be viewed (preventing rendering)Content-Type: application/octet-streamfor remaining filesContent-Disposition: attachmentfor files that can not be viewed to prevent inline renderingapplication/jsonandapplication/xmlare kept as is, to allow rendering them in the browser in a convenient way