Skip to content

Enable licensecheck#2966

Merged
rgrunber merged 1 commit intoeclipse-jdtls:masterfrom
akurtakov:enable_licensecheck
Nov 20, 2023
Merged

Enable licensecheck#2966
rgrunber merged 1 commit intoeclipse-jdtls:masterfrom
akurtakov:enable_licensecheck

Conversation

@akurtakov
Copy link
Copy Markdown
Contributor

No description provided.

@rgrunber
Copy link
Copy Markdown
Contributor

rgrunber commented Nov 17, 2023

All seem to pass but : 2/orbit/p2.eclipse.plugin/org.gradle.toolingapi/7.4.2.v20220712-0930-s, unknown, restricted, none .

It comes from https://www.eclipse.org/downloads/download.php?file=/buildship/updates/e423/snapshots/3.x/3.1.7.v20221108-1729-s/plugins/org.gradle.toolingapi_7.4.2.v20220712-0930-s.jar so it should be permitted.

@rgrunber
Copy link
Copy Markdown
Contributor

/request-license-review

@fbricon
Copy link
Copy Markdown
Contributor

fbricon commented Nov 20, 2023

/request-license-review

@rgrunber
Copy link
Copy Markdown
Contributor

@HannesWell
Copy link
Copy Markdown

/request-license-review

This can only work after the workflow has been submitted to the default branch of the repo.
Because only then this workflow is considered as listener to repository wide events like comment creation.

After this PE has been merged, you can still trigger a license review by adding that comment to this PR.

@rgrunber rgrunber added this to the End November 2023 milestone Nov 20, 2023
@rgrunber rgrunber merged commit 45aeb8d into eclipse-jdtls:master Nov 20, 2023
@akurtakov
Copy link
Copy Markdown
Contributor Author

@rgrunber now we need /request-license-review from committer

@rgrunber
Copy link
Copy Markdown
Contributor

/request-license-review

@akurtakov
Copy link
Copy Markdown
Contributor Author

@HannesWell
Copy link
Copy Markdown

Indeed, but I can't tell why this happens. In general it works:

Maybe this repo has stricter permissions?
I can try to investigate it tomorrow evening.

@HannesWell
Copy link
Copy Markdown

I just added the required permissions explicitly to the license-check-workflow:

You probably have to specify the permissions similary in the caller workflow, if this repo does not by default grant all-write permisions, just like I did it for m2e:

akurtakov added a commit to akurtakov/eclipse.jdt.ls that referenced this pull request Nov 22, 2023
rgrunber pushed a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants