Support "Add all missing imports"#2292
Merged
rgrunber merged 4 commits intoeclipse-jdtls:masterfrom Nov 4, 2022
Merged
Conversation
This was referenced Oct 24, 2022
This comment was marked as resolved.
This comment was marked as resolved.
Merged
3 tasks
CsCherrYY
force-pushed
the
cs-add-missing-imports
branch
from
f349c0e to
da7d096
Compare
Signed-off-by: Shi Chen <[email protected]>
CsCherrYY
force-pushed
the
cs-add-missing-imports
branch
from
92a8d2a to
5c326da
Compare
rgrunber
reviewed
Nov 3, 2022
Contributor
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Overall, this looks good. Just some small things to address/clarify.
Signed-off-by: Shi Chen <[email protected]>
Signed-off-by: Shi Chen <[email protected]>
Contributor
|
Looks like the failures are likely due to something that the change is regressing (relating to statics?). Once it's fixed I think this is definitely good to merge. |
Contributor
Author
|
the root cause is that we always return proposal (formerly code action for some cases), which will be resolved directly if a client doesn't support resolving the code action. The related logic has an extra static part here. Let me fix it. |
Signed-off-by: Shi Chen <[email protected]>
Contributor
Author
|
test this please |
Contributor
|
re-test this please. |
rgrunber
approved these changes
Nov 4, 2022
Contributor
rgrunber
left a comment
rgrunber
left a comment
There was a problem hiding this comment.
Change looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen [email protected]
The quickfix will be available when there is an unresolved type, and the source action will be available if the current file has unresolved type errors, the actions will only add missing imports and do not affect current import order.
addallmissingimports.mp4
see redhat-developer/vscode-java#2748
related to: redhat-developer/vscode-java#2753