Skip to content

AnnotateAssistTest1d8 test failed#1478

Merged
stephan-herrmann merged 1 commit intoeclipse-jdt:masterfrom
stephan-herrmann:issue736
Jun 26, 2024
Merged

AnnotateAssistTest1d8 test failed#1478
stephan-herrmann merged 1 commit intoeclipse-jdt:masterfrom
stephan-herrmann:issue736

Conversation

@stephan-herrmann
Copy link
Copy Markdown
Contributor

addresses the ClassCastException

fixes #736

addresses the ClassCastException

fixes eclipse-jdt#736
@stephan-herrmann
Copy link
Copy Markdown
Contributor Author

@iloveeclipse @jjohnstn From 3 attempts I got 2 timeouts (and one unrelated intermittent failure).

Who decides about the timeout? It seems that the current limit of 40 min. is not realistic.

@iloveeclipse
Copy link
Copy Markdown
Member

Who decides about the timeout? It seems that the current limit of 40 min. is not realistic.

See

timeout(time: 40, unit: 'MINUTES')

@stephan-herrmann
Copy link
Copy Markdown
Contributor Author

Who decides about the timeout? It seems that the current limit of 40 min. is not realistic.

See

timeout(time: 40, unit: 'MINUTES')

Thanks, so the timeout has been at 40 since @ktatavarthi created that file 2 years ago (#1)

Asked differently: does everybody think this is the right threshold?

@stephan-herrmann stephan-herrmann merged commit fafdd0e into eclipse-jdt:master Jun 26, 2024
@stephan-herrmann stephan-herrmann deleted the issue736 branch June 26, 2024 15:53
@akurtakov
Copy link
Copy Markdown
Contributor

Looking at https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/master/buildTimeTrend - normal build is usually around ~25 minutes. What we see is probably related to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4063#note_2472456 . Meanwhile it should be fine to bump it to e.g. 60 minutes (twice slower than average time) so people don't have to restart builds like that.

@stephan-herrmann
Copy link
Copy Markdown
Contributor Author

Looking at https://ci.eclipse.org/jdt/job/eclipse.jdt.ui-github/job/master/buildTimeTrend - normal build is usually around ~25 minutes. What we see is probably related to https://gitlab.eclipse.org/eclipsefdn/helpdesk/-/issues/4063#note_2472456 . Meanwhile it should be fine to bump it to e.g. 60 minutes (twice slower than average time) so people don't have to restart builds like that.

Thanks, will do if/when I run into this problem again in the near future :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AnnotateAssistTest1d8 test failed

3 participants