Allow re-use by making these public with a public constructor#949
Merged
jansupol merged 1 commit intoeclipse-ee4j:2.xfrom Dec 11, 2025
Merged
Allow re-use by making these public with a public constructor#949jansupol merged 1 commit intoeclipse-ee4j:2.xfrom
jansupol merged 1 commit intoeclipse-ee4j:2.xfrom
Conversation
arjantijms
approved these changes
Dec 11, 2025
jansupol
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow public construction on classes that can be used to configure Tyrus/Grizzly programmatically. I can see maybe wanting GrizzlyServerFilter as a non-public helper, although, I think this is central enough that you should be proud to make it available. WebSocketAddOn just needs to be public for the sake of creating and configuring a grizzly server.