Add comprehensive unit test set for faces.js 4.1#5690
Merged
Conversation
Added initial test on direct members of faces namespace
…_test_set_for_faces.js
…t_set_for_faces.js Add comprehensive unit test set for faces.js
(there are failing tests; they will be addressed)
it was never defined in 4.1 spec
fallback on namespaced jakarta.faces.ClientWindow param when UIViewRoot is an instance of NamingContainer (portlets e.g)
removal matches "modern web browsers", it violated the spec which explicitly says that onclose must be invoked with -1 when window.WebSocket is unavailable; morever even in modern browsers the window.WebSocket can still be unavailable by e.g. corporate-induced browser extensions or in web workers
singleton (shared across all requests) to a constructor (each request gets its own queue), breaking the spec-required ordering guarantee that requests are sent in the same order as when they were initiated
Contributor
Author
|
Build passed. I'll merge directly so we can move forward for 5.0. |
Contributor
|
🔝 @BalusC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the TCK due to its E2E nature is not guaranteed to cover everything, and also because 4.1 had a big rewrite of faces.js as compared to 4.0 ( 1181d6d ) and I wanted to doublecheck if everything is still rock solid.
The new faces.js unit test suite indeed did uncover 4 bugs caused by the rewrite (there are 329 tests). They are all addressed.
// IE6-9comment, but it violated spec and still could potentially fail in e.g. corporate browsers and web workers, it has been restoredcc: @pizzi80