Conversation
|
Are you sure that this PR fix the bug? the IT test is failing and I'm able to reproduce the original bug basically the The View State hidden field is missing in the xml response ... it could be something related to PartialResponseWriter or similar? |
|
If test fails for you, you're most likely using outdated Mojarra version. I saw you was working on 4.1, did it have these changes merged in from 4.0? |
|
I'm testing from 4.1 latest ... github says that is in sync with upstream :| |
|
You're right, it passes in 4.0: https://github.com/eclipse-ee4j/mojarra/actions/runs/22456262784/job/65038163650 but it indeed fails in 4.1: https://github.com/eclipse-ee4j/mojarra/actions/runs/22281178716/job/64451965002 (unfold "Build with Maven" and scroll to bottom). I guess downmerge was done wrong. The script is changed a lot in 4.1 as compared to 4.0. I'll take a second look. |
|
thanks a lot! I'll work on it
I'm guilty :D ... By the way... I rebased my fork to 4.1 latest in the next few days I'll make a new wave of pull requests |
#5663