Skip to content

Fix #5663#5665

Merged
arjantijms merged 3 commits into4.0from
issue5663
Feb 22, 2026
Merged

Fix #5663#5665
arjantijms merged 3 commits into4.0from
issue5663

Conversation

@BalusC
Copy link
Copy Markdown
Contributor

@BalusC BalusC commented Feb 21, 2026

@BalusC BalusC requested review from arjantijms and mnriem February 21, 2026 14:36
@arjantijms arjantijms merged commit 7cddd77 into 4.0 Feb 22, 2026
3 checks passed
@BalusC BalusC added this to the 4.0.15 milestone Feb 22, 2026
@BalusC BalusC deleted the issue5663 branch February 22, 2026 16:38
@pizzi80
Copy link
Copy Markdown
Contributor

pizzi80 commented Mar 3, 2026

Are you sure that this PR fix the bug?

the IT test is failing and I'm able to reproduce the original bug
in a playground webapp

basically the The View State hidden field is missing in the xml response
of the first ajax request, and the second ajax request do nothig

... it could be something related to PartialResponseWriter or similar?

@BalusC
Copy link
Copy Markdown
Contributor Author

BalusC commented Mar 3, 2026

If test fails for you, you're most likely using outdated Mojarra version. I saw you was working on 4.1, did it have these changes merged in from 4.0?

@pizzi80
Copy link
Copy Markdown
Contributor

pizzi80 commented Mar 3, 2026

I'm testing from 4.1 latest ... github says that is in sync with upstream

https://github.com/pizzi80/mojarra/tree/4.1

:|

@BalusC
Copy link
Copy Markdown
Contributor Author

BalusC commented Mar 3, 2026

You're right, it passes in 4.0: https://github.com/eclipse-ee4j/mojarra/actions/runs/22456262784/job/65038163650 but it indeed fails in 4.1: https://github.com/eclipse-ee4j/mojarra/actions/runs/22281178716/job/64451965002 (unfold "Build with Maven" and scroll to bottom). I guess downmerge was done wrong. The script is changed a lot in 4.1 as compared to 4.0. I'll take a second look.

@BalusC
Copy link
Copy Markdown
Contributor Author

BalusC commented Mar 3, 2026

@pizzi80 fixed now: f88ab95 please rinse and repeat

@pizzi80
Copy link
Copy Markdown
Contributor

pizzi80 commented Mar 4, 2026

thanks a lot!

I'll work on it

The script is changed a lot in 4.1 as compared to 4.0. I'll take a second look.

I'm guilty :D

... By the way... I rebased my fork to 4.1 latest
with the purpose to make a new wave of
faces.js optimizations...

in the next few days I'll make a new wave of pull requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants