Add clue to error log when flash is unavailable after server restart without session persistence#5566
Merged
Add clue to error log when flash is unavailable after server restart without session persistence#5566
Conversation
restart without session persistence
DGuhr
reviewed
Feb 18, 2025
There was a problem hiding this comment.
LGTM, if I may give my 2c as issue starter. One optional thing:
Would it make sense to add a guard-clause to
so there's no NPE thrown? I'm not very sure if there are other situations where this could happen, for me it was the JSF1094 though, so maybe throw that one, then, instead?
Contributor
Author
|
I added an unit test and sorted out the NPE. |
mnriem
reviewed
Mar 4, 2025
| static final String FLASH_NOW_REQUEST_KEY = FLASH_ATTRIBUTE_NAME + "n"; | ||
|
|
||
| private enum CONSTANTS { | ||
| enum CONSTANTS { |
Contributor
There was a problem hiding this comment.
Why is private being removed?
Contributor
Author
There was a problem hiding this comment.
So it's accessible from ELFlashTest in same package.
Contributor
There was a problem hiding this comment.
As I don't remember so I am just going to ask. Would this impact the signature tests?
Contributor
Author
There was a problem hiding this comment.
No idea. How do I run them so I can verify?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#5552